Re: [PATCH v2] Documentation: add ReviewingGuidelines

From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Date: Sep 20, 2022, 21:23 UTC
Message-ID: <20220920212350.f5do44qqduhyp46u@meerkat.local>
In-Reply-To: <CABPp-BEB_+YoKZ=U6NPc8J+KZyMSYRsom34CeqjxUCyw0=LEyg@mail.gmail.com>

On Mon, Sep 19, 2022 at 05:43:15PM -0700, Elijah Newren wrote:

Show 13 quoted lines

> > +- You may find that the limited context provided in the patch diff is sometimes
> > +  insufficient for a thorough review. In such cases, you can review patches in
> > +  your local tree by either applying patches with linkgit:git-am[1] or checking
> > +  out the associated branch from https://github.com/gitster/git once the series
> > +  is tracked there.
> 
> Lots of reviews also come with "Fetch-It-Via" instructions in the
> cover letter, making it really easy to grab.  Might be worth
> mentioning?
> 
> Also, would it make sense for us to replace "applying" with
> "downloading and applying", perhaps mentioning `b4 am` for the
> downloading half?

B4 can also "convert" a patch series into a pull request using "shazam". E.g.:

    b4 shazam -H <msgid>

This will do some behind-the-scenes magic and give you a FETCH_HEAD that you can review, check out into a new branch, merge, etc.

You can try this with this very thread, if you are inside the git's own repo:

	$ b4 shazam -H pull.1348.git.1662747205235.gitgitgadget@gmail.com
	Grabbing thread from lore.kernel.org/all/pull.1348.git.1662747205235.gitgitgadget%40gmail.com/t.mbox.gz
	Checking for newer revisions on https://lore.kernel.org/all/
	Analyzing 12 messages in the thread
	Will use the latest revision: v2
	You can pick other revisions using the -vN flag
	Checking attestation on all messages, may take a moment...
	---
	  ✓ [PATCH v2] Documentation: add ReviewingGuidelines
		+ Reviewed-by: Josh Steadmon <steadmon@google.com> (✓ DKIM/google.com)
	  ---
	  ✓ Signed: DKIM/gmail.com
	---
	Total patches: 1
	---
	Magic: Preparing a sparse worktree
	---
	Applying: Documentation: add ReviewingGuidelines
	---
	Fetching into FETCH_HEAD
	You can now merge or checkout FETCH_HEAD
	  e.g.: git merge --no-ff -F /home/user/work/git/git/.git/b4-cover --edit FETCH_HEAD --signoff

> (I tend to use the Fetch-It-Via or wait for it to show up in
> gitster/git, but b4 is really nice for the other cases.)

Great to hear! :)

-Konstantin