git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/3] difftool: eliminate use of USE_THE_REPOSITORY_VARIABLE

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 7, 2025, 17:49 UTC
Message-ID
<xmqq4j15hch1.fsf@gitster.g>
In-Reply-To
<Z6WoEjEo9Seffm_q@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 8 quoted lines
> On Thu, Feb 06, 2025 at 12:31:14AM -0800, Elijah Newren wrote:
>> On Wed, Feb 5, 2025 at 8:20 PM David Aguilar <davvid@gmail.com> wrote:
>> ...
>> 
>> Nice; thanks for working on this.
>
> Yup, thanks for rerolling. This version is much easier to read indeed
> and looks good to me.

Thanks, all, for working on this and reviewing the patches. Looking very good.

Let me mark the topic for 'next'.
Previous: Patrick SteinhardtNext: Elijah Newren
Message 7 of 13 in “difftool: eliminate use of global variables”
  1. 1/3 difftool: eliminate use of global variablesDavid Aguilar, Feb 6, 2025
  2. 2/3 difftool: eliminate use of the_repositoryDavid Aguilar, Feb 6, 2025
  3. Elijah NewrenFeb 6, 2025
  4. 3/3 difftool: eliminate use of USE_THE_REPOSITORY_VARIABLEDavid Aguilar, Feb 6, 2025
  5. Elijah NewrenFeb 6, 2025
  6. Patrick SteinhardtFeb 7, 2025
  7. Junio C HamanoFeb 7, 2025
  8. Elijah NewrenFeb 6, 2025
  9. David AguilarFeb 7, 2025
  10. Junio C HamanoFeb 6, 2025
  11. Elijah NewrenFeb 6, 2025
  12. Junio C HamanoFeb 6, 2025
  13. Patrick SteinhardtFeb 7, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.