git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/3] difftool: eliminate use of USE_THE_REPOSITORY_VARIABLE

From
David Aguilar <davvid@gmail.com>
Date
Feb 6, 2025, 04:20 UTC
Message-ID
<20250206042010.865947-3-davvid@gmail.com>
In-Reply-To
<20250206042010.865947-1-davvid@gmail.com>

Remove the USE_THE_REPOSITORY_VARIABLE #define now that all state is passed to each function from callers.

Signed-off-by: David Aguilar <davvid@gmail.com>
---
 builtin/difftool.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/builtin/difftool.c b/builtin/difftool.c
index 81d733dfdf..41cd00066c 100644
--- a/builtin/difftool.c
+++ b/builtin/difftool.c
@@ -12,8 +12,6 @@
  * Copyright (C) 2016 Johannes Schindelin
  */
 
-#define USE_THE_REPOSITORY_VARIABLE
-
 #include "builtin.h"
 
 #include "abspath.h"
-- 
2.48.1.461.g612e419e04
Previous: Elijah NewrenNext: Elijah Newren
Message 4 of 13 in “difftool: eliminate use of global variables”
  1. 1/3 difftool: eliminate use of global variablesDavid Aguilar, Feb 6, 2025
  2. 2/3 difftool: eliminate use of the_repositoryDavid Aguilar, Feb 6, 2025
  3. Elijah NewrenFeb 6, 2025
  4. 3/3 difftool: eliminate use of USE_THE_REPOSITORY_VARIABLEDavid Aguilar, Feb 6, 2025
  5. Elijah NewrenFeb 6, 2025
  6. Patrick SteinhardtFeb 7, 2025
  7. Junio C HamanoFeb 7, 2025
  8. Elijah NewrenFeb 6, 2025
  9. David AguilarFeb 7, 2025
  10. Junio C HamanoFeb 6, 2025
  11. Elijah NewrenFeb 6, 2025
  12. Junio C HamanoFeb 6, 2025
  13. Patrick SteinhardtFeb 7, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.