Re: [PATCH v2 3/3] difftool: eliminate use of USE_THE_REPOSITORY_VARIABLE

From: Elijah Newren <newren@gmail.com>
Date: Feb 6, 2025, 08:31 UTC
Message-ID: <CABPp-BGi51EQvPOgaz8p0RjAJ0zDDeTpMDp__puz_wQH5wowXw@mail.gmail.com>
In-Reply-To: <20250206042010.865947-3-davvid@gmail.com>

On Wed, Feb 5, 2025 at 8:20 PM David Aguilar <davvid@gmail.com> wrote:

Show 24 quoted lines

>
> Remove the USE_THE_REPOSITORY_VARIABLE #define now that all
> state is passed to each function from callers.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
>  builtin/difftool.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/builtin/difftool.c b/builtin/difftool.c
> index 81d733dfdf..41cd00066c 100644
> --- a/builtin/difftool.c
> +++ b/builtin/difftool.c
> @@ -12,8 +12,6 @@
>   * Copyright (C) 2016 Johannes Schindelin
>   */
>
> -#define USE_THE_REPOSITORY_VARIABLE
> -
>  #include "builtin.h"
>
>  #include "abspath.h"
> --
> 2.48.1.461.g612e419e04

Nice; thanks for working on this.