Re: [PATCH v2 0/2] use __builtin_add_overflow() in st_add() with Clang
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 19, 2026, 00:57 UTC
- Message-ID
- <xmqq4ik4b4ia.fsf@gitster.g>
- In-Reply-To
- <20260518202502.25682-1-l.s.r@web.de>
René Scharfe <l.s.r@web.de> writes:
Show 7 quoted lines
> Changes since v2: > - Pass variable instead of st_add3() expression to ALLOC_GROW. > - Add the helper st_add_overflow() that mimics __builtin_add_overflow() > for size_t to avoid duplicating most of the definition of st_add(). > > strbuf: use st_add3() in strbuf_grow() > use __builtin_add_overflow() in st_add() with Clang
Nice simplification without becoming overly ambitious. Very well done.
Let me mark it for 'next'.
Thanks.