git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] use __builtin_add_overflow() in st_add() with Clang

From
Jeff King <peff@peff.net>
Date
May 15, 2026, 16:53 UTC
Message-ID
<20260515165324.GB88375@coredump.intra.peff.net>
In-Reply-To
<26b71f9c-0cc5-4bfd-9175-f45b584e202e@web.de>
On Fri, May 15, 2026 at 04:36:15PM +0200, René Scharfe wrote:
Show 9 quoted lines
> > I guess the ideal primitive is probably a wrapper with the same
> > interface as __builtin_add_overflow(), which could then be used
> > everywhere that unsigned_add_overflows() with some minor conversion.
> 
> Junio said the same. :)
> > But it gets awkward to do as a macro, and using an inline function runs
> > into type questions.
> Indeed.  If it was easy then this wouldn't exist as a builtin.  We
> can approximate it somewhat, but will it be robust enough?

I always thought it was a builtin because the most efficient way involves checking the carry flag, which can't be accessed from C.

But yeah, the type issues are real, too. ;)

I think we should take what you posted for now, and we can iterate on a more general add-and-check interface later (or never if it's too tricky).

-Peff
Previous: René ScharfeNext: Junio C Hamano
Message 8 of 18 in “strbuf: use st_add3() in strbuf_grow()”
  1. 1/2 strbuf: use st_add3() in strbuf_grow()René Scharfe, May 14, 2026
  2. 2/2 use __builtin_add_overflow() in st_add() with ClangRené Scharfe, May 14, 2026
  3. Junio C HamanoMay 14, 2026
  4. René ScharfeMay 14, 2026
  5. René ScharfeMay 15, 2026
  6. Jeff KingMay 15, 2026
  7. René ScharfeMay 15, 2026
  8. Jeff KingMay 15, 2026
  9. Junio C HamanoMay 14, 2026
  10. René ScharfeMay 14, 2026
  11. Jeff KingMay 15, 2026
  12. René ScharfeMay 15, 2026
  13. Jeff KingMay 15, 2026
  14. 0/2 use __builtin_add_overflow() in st_add() with ClangRené Scharfe, May 18, 2026
  15. 2/2 use __builtin_add_overflow() in st_add() with ClangRené Scharfe, May 18, 2026
  16. 1/2 strbuf: use st_add3() in strbuf_grow()René Scharfe, May 18, 2026
  17. Jeff KingMay 19, 2026
  18. Junio C HamanoMay 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.