git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] strbuf: use st_add3() in strbuf_grow()

From
Jeff King <peff@peff.net>
Date
May 15, 2026, 16:50 UTC
Message-ID
<20260515165059.GA88375@coredump.intra.peff.net>
In-Reply-To
<459f5f2b-2565-4dae-9f9f-8848a5cb9d94@web.de>
On Fri, May 15, 2026 at 04:30:34PM +0200, René Scharfe wrote:
Show 10 quoted lines
> > That's all assuming that no overflow happens before ALLOC_GROW() gets
> > the values. We also tend to do unchecked computions for the "nr" field
> > there, but it's usually just "nr_foo + 1", so the same logic applies:
> > you'd have to have an existing array consuming the entire address space
> > minus one byte to trigger an overflow.
>
> The use in read-cache.c::do_read_index() looks odd.  Has been present
> since commit one.  Is the point that it over-allocates to have room for
> additions right from the start?  For read-only commands this only wastes
> memory, no?

Hmm, yeah, that is weird, and unusual to use alloc_nr() directly. We are presumably picking up istate->cache_nr from the on-disk file, so it could be anything, and that alloc_nr() could overflow.

We'd store the too-small value in alloc, so we _know_ it's too small. So later when we use ALLOC_GROW(), the problem would be resolved as we grow the array. I'm not convinced the initial load might not overflow the array, though.

-Peff
Previous: René ScharfeNext: René Scharfe
Message 13 of 18 in “strbuf: use st_add3() in strbuf_grow()”
  1. 1/2 strbuf: use st_add3() in strbuf_grow()René Scharfe, May 14, 2026
  2. 2/2 use __builtin_add_overflow() in st_add() with ClangRené Scharfe, May 14, 2026
  3. Junio C HamanoMay 14, 2026
  4. René ScharfeMay 14, 2026
  5. René ScharfeMay 15, 2026
  6. Jeff KingMay 15, 2026
  7. René ScharfeMay 15, 2026
  8. Jeff KingMay 15, 2026
  9. Junio C HamanoMay 14, 2026
  10. René ScharfeMay 14, 2026
  11. Jeff KingMay 15, 2026
  12. René ScharfeMay 15, 2026
  13. Jeff KingMay 15, 2026
  14. 0/2 use __builtin_add_overflow() in st_add() with ClangRené Scharfe, May 18, 2026
  15. 2/2 use __builtin_add_overflow() in st_add() with ClangRené Scharfe, May 18, 2026
  16. 1/2 strbuf: use st_add3() in strbuf_grow()René Scharfe, May 18, 2026
  17. Jeff KingMay 19, 2026
  18. Junio C HamanoMay 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.