Re: [PATCH v2 0/2] use __builtin_add_overflow() in st_add() with Clang
- From
Jeff King <peff@peff.net>
- Date
- May 19, 2026, 00:44 UTC
- Message-ID
- <20260519004401.GB1612961@coredump.intra.peff.net>
- In-Reply-To
- <20260518202502.25682-1-l.s.r@web.de>
On Mon, May 18, 2026 at 10:25:00PM +0200, René Scharfe wrote:
Show 7 quoted lines
> Changes since v2: > - Pass variable instead of st_add3() expression to ALLOC_GROW. > - Add the helper st_add_overflow() that mimics __builtin_add_overflow() > for size_t to avoid duplicating most of the definition of st_add(). > > strbuf: use st_add3() in strbuf_grow() > use __builtin_add_overflow() in st_add() with Clang
Thanks, this seems reasonable to me. The type-generic version of builtin_add_overflow() is much harder, but doing it just for st_add() is enough for our purposes here.
-Peff