Re: [PATCH v14 7/8] history: create squashed commits without editing

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 20, 2026, 20:10 UTC
Message-ID: <xmqq4igov9h9.fsf@gitster.g>
In-Reply-To: <03528d3b34c202b990cc42865a009a5786255b7c.1787249432.git.gitgitgadget@gmail.com>

"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 8 quoted lines

> +	/*
> +	 * Allow "fixup! <hex object id>", but not "fixup! HEAD^" or
> +	 * "fixup! main". If the target is not being squshed check the subject
> +	 * to allow "fixup! abc123" and "fixup! <subject of abc123>" to be
> +	 * squashed together.
> +	 */
> +	target = lookup_commit_reference_by_name(s);
> +	if (target && istarts_with(oid_to_hex(&target->object.oid), s)) {

Why istarts_with()?  "fixup! ABCdef" should not be accepted, should it?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.