Re: [PATCH v7 0/5] history: add squash subcommand to fold a range
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- Jul 7, 2026, 08:55 UTC
- Message-ID
- <CAHwyqnVd2OsmD-Y4YKVr9GsYdHRRNDot5EKSSESoRM-mf82YSg@mail.gmail.com>
- In-Reply-To
- <CAHwyqnVxa34iGmFvL4Ujrc2dTbmtF+7j7b=q5v95y=-pzUf0NA@mail.gmail.com>
Show 8 quoted lines
> > The range-diff does not show any input sanitization - what happens when > > the user passes "--reverse" for example? As I said in [4] we should copy > > what "git replay" does to sanity check the rev-list options, otherwise > > we've got no idea whether the parent of the first commit returned by > > get_revision() is the commit we want to use as the parent of the > > squashed commit. > > Yeah, good point.
Well, the code already blocks "--reverse" and other unknown options, but I can clarify that better in the commit message.
Harald