From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 20 Aug 2026 20:10:42 GMT
Subject: Re: [PATCH v14 7/8] history: create squashed commits without editing
Message-ID: <xmqq4igov9h9.fsf@gitster.g>
In-Reply-To: <03528d3b34c202b990cc42865a009a5786255b7c.1787249432.git.gitgitgadget@gmail.com>

"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> +	/*
> +	 * Allow "fixup! <hex object id>", but not "fixup! HEAD^" or
> +	 * "fixup! main". If the target is not being squshed check the subject
> +	 * to allow "fixup! abc123" and "fixup! <subject of abc123>" to be
> +	 * squashed together.
> +	 */
> +	target = lookup_commit_reference_by_name(s);
> +	if (target && istarts_with(oid_to_hex(&target->object.oid), s)) {

Why istarts_with()?  "fixup! ABCdef" should not be accepted, should it?