Re: [PATCH v13 7/8] history: create squashed commits without editing

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Aug 17, 2026, 20:07 UTC
Message-ID: <29d56a3e-6bde-49a2-b7b2-3eeb4c439e01@app.fastmail.com>
In-Reply-To: <CAHwyqnXVepLAsNZHZe_qqXbqYjBt6RpDXVQUP3s7vPwbEg2FXw@mail.gmail.com>

On Mon, Aug 17, 2026, at 19:38, Harald Nordgren wrote:

Show 13 quoted lines

>>  >> Inspired-by: Sergey Chernov <serega.morph@gmail.com>
>>  >> Helped-by: Phillip Wood <phillip.wood@dunelm.org.uk>
>>  >> Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
>>
>> Thanks for the Helped-by: trailer, but this and several of the other
>> patches are missing my sign off from the fixup patches I sent. My sign
>> off should come above yours to reflect the chain of custody.
>
> Got it, should I use both headers?
>
>     Helped-by: Phillip Wood <phillip.wood@dunelm.org.uk>
>     Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
>     Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>

In general swapping the first and second makes more sense.

    S: PW
    H: PW
    S: HN

Because as a chain of custody this says: Phillip signed off, then Harald said that PW helped him, then Harald signed off on what he got from PW with perhaps his own changes mixed in.

sent from mobile