git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t/Makefile: always test all lint targets when running tests

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 7, 2014, 18:13 UTC
Message-ID
<xmqq38eddolk.fsf@gitster.dls.corp.google.com>
In-Reply-To
<53B5D76D.1090509@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
Show 6 quoted lines
> Only the two targets "test-lint-duplicates" and "test-lint-executable" are
> currently executed when running the test target. This was done on purpose
> when the TEST_LINT variable was added in 81127d74. But as this does not
> include the "test-lint-shell-syntax" target added the same day in commit
> c7ce70ac, it is easy to accidentally add non portable shell constructs
> without noticing that when running the test suite.

I not running the lint-shell-syntax that is fundamentally flaky to avoid false positives is very much on purpose. The flakiness is not the fault of the implementor of the lint-shell-syntax, but comes from the approach taken to pretend that simple pattern matching can parse shell scripts. It may not complain on the current set of scripts, but that is not really by design but by accident.

So I am not very enthusiastic to see this change myself.
Previous: Jens LehmannNext: Jens Lehmann
Message 4 of 10 in “always run all lint targets when running the test suite”
  1. 0/2 always run all lint targets when running the test suiteJens Lehmann, Jul 3, 2014
  2. 1/2 t/Makefile: check helper scripts for non-portable shell commands tooJens Lehmann, Jul 3, 2014
  3. 2/2 t/Makefile: always test all lint targets when running testsJens Lehmann, Jul 3, 2014
  4. Junio C HamanoJul 7, 2014
  5. Jens LehmannJul 8, 2014
  6. Junio C HamanoJul 9, 2014
  7. 0/2 always run all lint targets when running the test suiteJens Lehmann, Jul 9, 2014
  8. 1/2 t/Makefile: check helper scripts for non-portable shell commands tooJens Lehmann, Jul 9, 2014
  9. 2/2 t/Makefile: always test all lint targets when running testsJens Lehmann, Jul 9, 2014
  10. Jeff KingJul 9, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.