git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] t/Makefile: always test all lint targets when running tests

From
Jens Lehmann <jens.lehmann@web.de>
Date
Jul 9, 2014, 19:34 UTC
Message-ID
<53BD9952.8060109@web.de>
In-Reply-To
<53BD9908.1060807@web.de>

Only the two targets "test-lint-duplicates" and "test-lint-executable" are currently executed when running the test target. This was done on purpose when the TEST_LINT variable was added in 81127d74 to avoid twisted shell scripting by developers only to avoid false positives that might result from the rather simple minded tests, e.g. test-lint-shell-syntax. But it looks like it might be better to include all lint tests to help developers to detect non portable shell constructs before the patch is sent to the list and reviewed there.

Change the TEST_LINT variable to run all lint test unless the TEST_LINT variable is overridden. If we hit false positives more often than helping developers to avoid non-portable code (or add less accurate or slow tests later) we could still fall back to exclude them like 81127d74 proposed.

Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
---
 t/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/Makefile b/t/Makefile
index 7fa6692..43b15e3 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -13,7 +13,7 @@ TAR ?= $(TAR)
 RM ?= rm -f
 PROVE ?= prove
 DEFAULT_TEST_TARGET ?= test
-TEST_LINT ?= test-lint-duplicates test-lint-executable
+TEST_LINT ?= test-lint

 ifdef TEST_OUTPUT_DIRECTORY
 TEST_RESULTS_DIRECTORY = $(TEST_OUTPUT_DIRECTORY)/test-results
-- 
2.0.1.476.gf051ede
Previous: Jens LehmannNext: Jeff King
Message 9 of 10 in “always run all lint targets when running the test suite”
  1. 0/2 always run all lint targets when running the test suiteJens Lehmann, Jul 3, 2014
  2. 1/2 t/Makefile: check helper scripts for non-portable shell commands tooJens Lehmann, Jul 3, 2014
  3. 2/2 t/Makefile: always test all lint targets when running testsJens Lehmann, Jul 3, 2014
  4. Junio C HamanoJul 7, 2014
  5. Jens LehmannJul 8, 2014
  6. Junio C HamanoJul 9, 2014
  7. 0/2 always run all lint targets when running the test suiteJens Lehmann, Jul 9, 2014
  8. 1/2 t/Makefile: check helper scripts for non-portable shell commands tooJens Lehmann, Jul 9, 2014
  9. 2/2 t/Makefile: always test all lint targets when running testsJens Lehmann, Jul 9, 2014
  10. Jeff KingJul 9, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.