git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t/Makefile: always test all lint targets when running tests

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 9, 2014, 05:42 UTC
Message-ID
<CAPc5daUXZNB=2X8zsrhs9=Z-nV1o1v7KWGydAj6UmBk23UBEEw@mail.gmail.com>
In-Reply-To
<53BC4569.3020907@web.de>
On Tue, Jul 8, 2014 at 12:24 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
Show 8 quoted lines
>
> Am 07.07.2014 20:13, schrieb Junio C Hamano:
> >
> > So I am not very enthusiastic to see this change myself.
>
> Ok, I understand we do not want to lightly risk false positives. I
> just noticed that I accidentally forgot to sign off this series, so
> I'd resend just the first patch with a proper SOB, ok?

Nah, let's do both and how it plays out. My not being very enthusiastic myself does not necessarily mean that it is bad for the project. Maybe most people like it and if I cannot bear with it I can always turn it off myself for my environment.

I just have a strange feeling that we may be seeing some twisted shell script updates and when the author gets asked why it was written in such a strange way, the answer might turn out to be "just to work around the false positive from the test-lint", which I would not want to see.

Previous: Jens LehmannNext: Jens Lehmann
Message 6 of 10 in “always run all lint targets when running the test suite”
  1. 0/2 always run all lint targets when running the test suiteJens Lehmann, Jul 3, 2014
  2. 1/2 t/Makefile: check helper scripts for non-portable shell commands tooJens Lehmann, Jul 3, 2014
  3. 2/2 t/Makefile: always test all lint targets when running testsJens Lehmann, Jul 3, 2014
  4. Junio C HamanoJul 7, 2014
  5. Jens LehmannJul 8, 2014
  6. Junio C HamanoJul 9, 2014
  7. 0/2 always run all lint targets when running the test suiteJens Lehmann, Jul 9, 2014
  8. 1/2 t/Makefile: check helper scripts for non-portable shell commands tooJens Lehmann, Jul 9, 2014
  9. 2/2 t/Makefile: always test all lint targets when running testsJens Lehmann, Jul 9, 2014
  10. Jeff KingJul 9, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.