git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] t/Makefile: always test all lint targets when running tests

From
Jens Lehmann <jens.lehmann@web.de>
Date
Jul 3, 2014, 22:21 UTC
Message-ID
<53B5D76D.1090509@web.de>
In-Reply-To
<53B5D6FE.2090700@web.de>

Only the two targets "test-lint-duplicates" and "test-lint-executable" are currently executed when running the test target. This was done on purpose when the TEST_LINT variable was added in 81127d74. But as this does not include the "test-lint-shell-syntax" target added the same day in commit c7ce70ac, it is easy to accidentally add non portable shell constructs without noticing that when running the test suite.

Fix that by always running all lint tests unless the TEST_LINT variable is
overridden. If we add less accurate or slow tests later we could still
fall back to exclude them like 81127d74 proposed. But for now it is better
to include all lint tests until proven otherwise.
---
 t/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/Makefile b/t/Makefile
index 7fa6692..43b15e3 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -13,7 +13,7 @@ TAR ?= $(TAR)
 RM ?= rm -f
 PROVE ?= prove
 DEFAULT_TEST_TARGET ?= test
-TEST_LINT ?= test-lint-duplicates test-lint-executable
+TEST_LINT ?= test-lint

 ifdef TEST_OUTPUT_DIRECTORY
 TEST_RESULTS_DIRECTORY = $(TEST_OUTPUT_DIRECTORY)/test-results
-- 
2.0.1.474.g5b85b58
Previous: Jens LehmannNext: Junio C Hamano
Message 3 of 10 in “always run all lint targets when running the test suite”
  1. 0/2 always run all lint targets when running the test suiteJens Lehmann, Jul 3, 2014
  2. 1/2 t/Makefile: check helper scripts for non-portable shell commands tooJens Lehmann, Jul 3, 2014
  3. 2/2 t/Makefile: always test all lint targets when running testsJens Lehmann, Jul 3, 2014
  4. Junio C HamanoJul 7, 2014
  5. Jens LehmannJul 8, 2014
  6. Junio C HamanoJul 9, 2014
  7. 0/2 always run all lint targets when running the test suiteJens Lehmann, Jul 9, 2014
  8. 1/2 t/Makefile: check helper scripts for non-portable shell commands tooJens Lehmann, Jul 9, 2014
  9. 2/2 t/Makefile: always test all lint targets when running testsJens Lehmann, Jul 9, 2014
  10. Jeff KingJul 9, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.