git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: add tests for --relative without optional prefix value

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 7, 2017, 19:17 UTC
Message-ID
<xmqq374me4a7.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20171207190135.28660-1-jacob.e.keller@intel.com>
Jacob Keller <jacob.e.keller@intel.com> writes:
Show 8 quoted lines
>  for type in diff numstat stat raw; do
> -	check_$type file2 --relative=subdir/
> -	check_$type file2 --relative=subdir
> -	check_$type dir/file2 --relative=sub
> +	check_$type . file2 --relative=subdir/
> +	check_$type . file2 --relative=subdir
> +	check_$type . dir/file2 --relative=sub
> +	check_$type subdir file2 --relative

OK, I didn't think it would be sensible to unconditionally pass the directory and use "-C ." as a no-op. It looks good.

I think the new one should go before the dir/file2 test; all three earlier tests (including this new one) are about taking a patch relative to subdir/ spelled in different ways, and the one about dir/file2 alone is different.

Previous: Jacob KellerNext: Jacob Keller
Message 2 of 7 in “diff: add tests for --relative without optional prefix value”
  1. diff: add tests for --relative without optional prefix valueJacob Keller, Dec 7, 2017
  2. Junio C HamanoDec 7, 2017
  3. Jacob KellerDec 7, 2017
  4. Jeff KingDec 7, 2017
  5. Jacob KellerDec 7, 2017
  6. Junio C HamanoDec 7, 2017
  7. Jacob KellerDec 7, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.