git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: add tests for --relative without optional prefix value

From
Jeff King <peff@peff.net>
Date
Dec 7, 2017, 21:12 UTC
Message-ID
<20171207211258.GB12850@sigill.intra.peff.net>
In-Reply-To
<20171207190135.28660-1-jacob.e.keller@intel.com>
On Thu, Dec 07, 2017 at 11:01:35AM -0800, Jacob Keller wrote:
Show 9 quoted lines
> From: Jacob Keller <jacob.keller@gmail.com>
> 
> We already have tests for --relative, but they currently only test when
> a prefix has been provided. This fails to test the case where --relative
> by itself should use the current directory as the prefix.
> 
> Teach the check_$type functions to take a directory argument to indicate
> which subdirectory to run the git commands in. Add a new test which uses
> this to test --relative without a prefix value.

This looks good to me (and I slightly prefer it over Junio's for the simplicity).

I agree on the ordering suggestion Junio made.
-Peff
Previous: Jacob KellerNext: Jacob Keller
Message 4 of 7 in “diff: add tests for --relative without optional prefix value”
  1. diff: add tests for --relative without optional prefix valueJacob Keller, Dec 7, 2017
  2. Junio C HamanoDec 7, 2017
  3. Jacob KellerDec 7, 2017
  4. Jeff KingDec 7, 2017
  5. Jacob KellerDec 7, 2017
  6. Junio C HamanoDec 7, 2017
  7. Jacob KellerDec 7, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.