Re: [PATCH] diff: add tests for --relative without optional prefix value

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 7, 2017, 21:50 UTC
Message-ID: <xmqqtvx2b41s.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171207211258.GB12850@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 16 quoted lines

> On Thu, Dec 07, 2017 at 11:01:35AM -0800, Jacob Keller wrote:
>
>> From: Jacob Keller <jacob.keller@gmail.com>
>> 
>> We already have tests for --relative, but they currently only test when
>> a prefix has been provided. This fails to test the case where --relative
>> by itself should use the current directory as the prefix.
>> 
>> Teach the check_$type functions to take a directory argument to indicate
>> which subdirectory to run the git commands in. Add a new test which uses
>> this to test --relative without a prefix value.
>
> This looks good to me (and I slightly prefer it over Junio's for the
> simplicity).
>
> I agree on the ordering suggestion Junio made.

I also prefer this one over the other one, provided if it is ported on top of the preliminary clean-up I did in the other one.

Thanks.