From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 07 Dec 2017 19:17:36 GMT
Subject: Re: [PATCH] diff: add tests for --relative without optional prefix value
Message-ID: <xmqq374me4a7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171207190135.28660-1-jacob.e.keller@intel.com>

Jacob Keller <jacob.e.keller@intel.com> writes:

>  for type in diff numstat stat raw; do
> -	check_$type file2 --relative=subdir/
> -	check_$type file2 --relative=subdir
> -	check_$type dir/file2 --relative=sub
> +	check_$type . file2 --relative=subdir/
> +	check_$type . file2 --relative=subdir
> +	check_$type . dir/file2 --relative=sub
> +	check_$type subdir file2 --relative

OK, I didn't think it would be sensible to unconditionally pass the
directory and use "-C ." as a no-op.  It looks good.

I think the new one should go before the dir/file2 test; all three
earlier tests (including this new one) are about taking a patch
relative to subdir/ spelled in different ways, and the one about
dir/file2 alone is different.