Re: [PATCH v2 2/5] preload-index: teach GIT_FORCE_PRELOAD_TEST to take a boolean

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 14, 2018, 21:54 UTC
Message-ID: <xmqq36ubbv8m.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180914205158.GC133420@aiede.svl.corp.google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 7 quoted lines

> Maybe something like:
>
> 	preload-index: use git_env_bool() not getenv() for customization
>
> 	GIT_FORCE_PRELOAD_TEST is only checked for presence by using getenv().
> 	Use git_env_bool() instead so that GIT_FORCE_PRELOAD_TEST=false can
> 	work as expected.

That is much better description.  Also

	$ cd t && GIT_FORCE_PRELOAD_TEST=t ./t0000-basic.sh

would have allowed us to enable the feature in the older world, but I suspect it would instead fail the test, saying 't is not a bool nor int'.

So strictly speaking, it is a backward incompatible change. I am not sure if I like it.

>> Teach GIT_FORCE_PRELOAD_TEST to take a boolean to turn on or off this test
>> feature instead of simply testing for existance.

s/existance/existence/?