Re: [PATCH v3 3/5] fsmonitor: update GIT_TEST_FSMONITOR support

From: Ben Peart <peartben@gmail.com>
Date: Sep 28, 2018, 14:27 UTC
Message-ID: <efe7ae90-d0c2-9223-cdab-8b6c64f818bd@gmail.com>
In-Reply-To: <653f4fbd-ed32-4cf8-b1bb-9cfef4f8deaa@gmail.com>

On 9/28/2018 10:21 AM, Ben Peart wrote:

Show 42 quoted lines

> 
> 
> On 9/28/2018 6:01 AM, SZEDER Gábor wrote:
>> On Tue, Sep 18, 2018 at 11:29:35PM +0000, Ben Peart wrote:
>>> diff --git a/t/README b/t/README
>>> index 56a417439c..47165f7eab 100644
>>> --- a/t/README
>>> +++ b/t/README
>>> @@ -319,6 +319,10 @@ GIT_TEST_OE_DELTA_SIZE=<n> exercises the 
>>> uncommon pack-objects code
>>>   path where deltas larger than this limit require extra memory
>>>   allocation for bookkeeping.
>>> +GIT_TEST_FSMONITOR=$PWD/t7519/fsmonitor-all exercises the fsmonitor
>>> +code path for utilizing a file system monitor to speed up detecting
>>> +new or changed files.
>>
>> Here you tell us to set GIT_TEST_FSMONITOR to an absolute path, and we
>> are good to go.
>>
>>> diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh
>>> index 756beb0d8e..d77012ea6d 100755
>>> --- a/t/t7519-status-fsmonitor.sh
>>> +++ b/t/t7519-status-fsmonitor.sh
>>> @@ -8,7 +8,7 @@ test_description='git status with file system watcher'
>>>   # To run the entire git test suite using fsmonitor:
>>>   #
>>>   # copy t/t7519/fsmonitor-all to a location in your path and then set
>>> -# GIT_FSMONITOR_TEST=fsmonitor-all and run your tests.
>>> +# GIT_TEST_FSMONITOR=fsmonitor-all and run your tests.
>>
>> But this old comment is different, suggesting copying that script to
>> our $PATH.
>>
>> I prefer your instructions above, because it's only a single step,
>> and, more importantly, it won't pollute my $PATH.  I think this
>> comment should be updated to make the advices in both places
>> consistent.  Or perhaps even removed, now that all GIT_TEST variables
>> are documented in the same place?
>>
> 
> I prefer the suggestion to simply remove this text from the test script 
> now that there is documentation for it in the t/README file.

Junio, can you squash in the following patch or would you prefer I reroll the entire series?

Thanks,

Ben

 From 393007340dc1baf3539ab727e0a8128e7c408a27 Mon Sep 17 00:00:00 2001
From: Ben Peart <peartben@gmail.com>
Date: Fri, 28 Sep 2018 10:23:18 -0400
Subject: fixup! fsmonitor: remove outdated instructions from test

Remove the outdated instructions on how to run the test suite utilizing fsmonitor now that it is properly documented in t/README.

Signed-off-by: Ben Peart <peartben@gmail.com>
---

Notes:
     Base Ref: git-test-cleanup-v3
     Web-Diff: https://github.com/benpeart/git/commit/393007340d
     Checkout: git fetch https://github.com/benpeart/git 
git-test-cleanup-v1 && git checkout 393007340d

  t/t7519-status-fsmonitor.sh | 7 -------
  1 file changed, 7 deletions(-)

diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh
index 8308d6d5b1..3f0dd98010 100755
--- a/t/t7519-status-fsmonitor.sh
+++ b/t/t7519-status-fsmonitor.sh
@@ -4,13 +4,6 @@ test_description='git status with file system watcher'

  . ./test-lib.sh

-#
-# To run the entire git test suite using fsmonitor:
-#
-# copy t/t7519/fsmonitor-all to a location in your path and then set
-# GIT_TEST_FSMONITOR=fsmonitor-all and run your tests.
-#
-
  # Note, after "git reset --hard HEAD" no extensions exist other than 
'TREE'
  # "git update-index --fsmonitor" can be used to get the extension written
  # before testing the results.

base-commit: 043246d9369fb851c5c2b922466f77fc7ef0327b

-- 
2.18.0.windows.1