Re: [PATCH v2 1/5] correct typo/spelling error in t/README

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 14, 2018, 20:43 UTC
Message-ID: <20180914204348.GB133420@aiede.svl.corp.google.com>
In-Reply-To: <20180914201340.37400-2-benpeart@microsoft.com>

Hi,

Ben Peart wrote:

> Subject: correct typo/spelling error in t/README

nit: what is the difference between a typo/spelling error and another kind of spelling error? Maybe this could be something like

	t/README: correct spelling of "uncommon"

which makes it crystal clear what the patch will do.

> Correct a spelling error in the documentation for GIT_TEST_OE_DELTA_SIZE

The commit message should consist of complete sentences, so this is missing a period. Alternatively, I think it would be fine to omit the sentence altogether.

> Signed-off-by: Ben Peart <Ben.Peart@microsoft.com>
> ---
>  t/README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This appears to be the only usage of uncomon in the code base. Thanks for fixing it.

With or without the commit message tweaks mentioned above,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.