git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 2/5] preload-index: use git_env_bool() not getenv() for customization

From
Ben Peart <benpeart@microsoft.com>
Date
Sep 18, 2018, 23:29 UTC
Message-ID
<20180918232916.57736-3-benpeart@microsoft.com>
In-Reply-To
<20180918232916.57736-1-benpeart@microsoft.com>

GIT_FORCE_PRELOAD_TEST is only checked for presence by using getenv(). Use git_env_bool() instead so that GIT_FORCE_PRELOAD_TEST=false can work as expected.

Signed-off-by: Ben Peart <Ben.Peart@microsoft.com>
---
 preload-index.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/preload-index.c b/preload-index.c
index 71cd2437a3..0a4e2933bb 100644
--- a/preload-index.c
+++ b/preload-index.c
@@ -5,6 +5,7 @@
 #include "pathspec.h"
 #include "dir.h"
 #include "fsmonitor.h"
+#include "config.h"
 
 #ifdef NO_PTHREADS
 static void preload_index(struct index_state *index,
@@ -84,7 +85,7 @@ static void preload_index(struct index_state *index,
 		return;
 
 	threads = index->cache_nr / THREAD_COST;
-	if ((index->cache_nr > 1) && (threads < 2) && getenv("GIT_FORCE_PRELOAD_TEST"))
+	if ((index->cache_nr > 1) && (threads < 2) && git_env_bool("GIT_FORCE_PRELOAD_TEST", 0))
 		threads = 2;
 	if (threads < 2)
 		return;
-- 
2.18.0.windows.1
Previous: Ben PeartNext: Ben Peart
Message 24 of 33 in “Cleanup pass on special test setups”
  1. 0/4 Cleanup pass on special test setupsBen Peart, Sep 14, 2018
  2. 1/4 correct typo/spelling error in t/READMEBen Peart, Sep 14, 2018
  3. 2/4 fsmonitor: update GIT_TEST_FSMONITOR supportBen Peart, Sep 14, 2018
  4. Junio C HamanoSep 14, 2018
  5. Junio C HamanoSep 14, 2018
  6. Junio C HamanoSep 14, 2018
  7. Ben PeartSep 14, 2018
  8. Junio C HamanoSep 14, 2018
  9. 0/5 Cleanup pass on special test setupsBen Peart, Sep 14, 2018
  10. 1/5 correct typo/spelling error in t/READMEBen Peart, Sep 14, 2018
  11. Jonathan NiederSep 14, 2018
  12. 2/5 preload-index: teach GIT_FORCE_PRELOAD_TEST to take a booleanBen Peart, Sep 14, 2018
  13. Jonathan NiederSep 14, 2018
  14. Junio C HamanoSep 14, 2018
  15. 3/5 fsmonitor: update GIT_TEST_FSMONITOR supportBen Peart, Sep 14, 2018
  16. 4/5 read-cache: update TEST_GIT_INDEX_VERSION supportBen Peart, Sep 14, 2018
  17. Junio C HamanoSep 14, 2018
  18. Junio C HamanoSep 14, 2018
  19. 5/5 preload-index: update GIT_FORCE_PRELOAD_TEST supportBen Peart, Sep 14, 2018
  20. 3/4 read-cache: update TEST_GIT_INDEX_VERSION supportBen Peart, Sep 14, 2018
  21. 4/4 preload-index: update GIT_FORCE_PRELOAD_TEST supportBen Peart, Sep 14, 2018
  22. 0/5 Cleanup pass on special test setupsBen Peart, Sep 18, 2018
  23. 1/5 t/README: correct spelling of "uncommon"Ben Peart, Sep 18, 2018
  24. 2/5 preload-index: use git_env_bool() not getenv() for customizationBen Peart, Sep 18, 2018
  25. 3/5 fsmonitor: update GIT_TEST_FSMONITOR supportBen Peart, Sep 18, 2018
  26. SZEDER GáborSep 28, 2018
  27. Ben PeartSep 28, 2018
  28. Ben PeartSep 28, 2018
  29. Junio C HamanoSep 28, 2018
  30. 4/5 read-cache: update TEST_GIT_INDEX_VERSION supportBen Peart, Sep 18, 2018
  31. 5/5 preload-index: update GIT_FORCE_PRELOAD_TEST supportBen Peart, Sep 18, 2018
  32. Re*: [PATCH v3 0/5] Cleanup pass on special test setupsJunio C Hamano, Sep 20, 2018
  33. Ben PeartSep 25, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.