git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 4/4] ref-filter: add support for %(contents:size)

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 8, 2020, 23:05 UTC
Message-ID
<xmqq36611ubf.fsf@gitster.c.googlers.com>
In-Reply-To
<20200707174049.21714-5-chriscool@tuxfamily.org>
Christian Couder <christian.couder@gmail.com> writes:
Show 9 quoted lines
> +# We cannot use test_atom to check contents:size of signed tags due to sanitize_pgp
> +test_tag_contents_size_pgp () {
> +	ref="$1"
> +	test_expect_success $PREREQ "basic atom: $ref contents:size" "
> +		git cat-file tag $ref | tail -n +6 | wc -c >expected &&
> +		git for-each-ref --format='%(contents:size)' $ref >actual &&
> +		test_cmp expected actual
> +	"
> +}

Of course, this will BREAK the tests on macOS and possibly others with "wc" that emits leading whitespaces before the number.

The tip of 'seen' has been failing ever since this topic was merged there e.g. https://travis-ci.org/github/git/git/jobs/705986794

Thanks.
Previous: Junio C HamanoNext: Christian Couder
Message 15 of 39 in “Add support for %(contents:size) in ref-filter”
  1. 0/4 Add support for %(contents:size) in ref-filterChristian Couder, Jul 7, 2020
  2. 1/4 Documentation: clarify %(contents:XXXX) docChristian Couder, Jul 7, 2020
  3. Junio C HamanoJul 7, 2020
  4. Christian CouderJul 10, 2020
  5. 2/4 Documentation: clarify 'complete message'Christian Couder, Jul 7, 2020
  6. Junio C HamanoJul 7, 2020
  7. 3/4 t6300: test refs pointing to tree and blobChristian Couder, Jul 7, 2020
  8. Junio C HamanoJul 7, 2020
  9. 4/4 ref-filter: add support for %(contents:size)Christian Couder, Jul 7, 2020
  10. Junio C HamanoJul 7, 2020
  11. Junio C HamanoJul 9, 2020
  12. Christian CouderJul 9, 2020
  13. Junio C HamanoJul 9, 2020
  14. Junio C HamanoJul 7, 2020
  15. Junio C HamanoJul 8, 2020
  16. 0/3 Add support for %(contents:size) in ref-filterChristian Couder, Jul 10, 2020
  17. 1/3 Documentation: clarify %(contents:XXXX) docChristian Couder, Jul 10, 2020
  18. Junio C HamanoJul 10, 2020
  19. 3/3 ref-filter: add support for %(contents:size)Christian Couder, Jul 10, 2020
  20. Junio C HamanoJul 10, 2020
  21. 2/3 t6300: test refs pointing to tree and blobChristian Couder, Jul 10, 2020
  22. Junio C HamanoJul 10, 2020
  23. 0/3 Add support for %(contents:size) in ref-filterChristian Couder, Jul 16, 2020
  24. 1/3 Documentation: clarify %(contents:XXXX) docChristian Couder, Jul 16, 2020
  25. 2/3 t6300: test refs pointing to tree and blobChristian Couder, Jul 16, 2020
  26. 3/3 ref-filter: add support for %(contents:size)Christian Couder, Jul 16, 2020
  27. Alban GruinJul 31, 2020
  28. t6300: fix issues related to %(contents:size)Alban Gruin, Jul 31, 2020
  29. Jeff KingJul 31, 2020
  30. Alban GruinJul 31, 2020
  31. Junio C HamanoJul 31, 2020
  32. Jeff KingJul 31, 2020
  33. t6300: fix issues related to %(contents:size)Alban Gruin, Jul 31, 2020
  34. Jeff KingJul 31, 2020
  35. Jeff KingJul 31, 2020
  36. Christian CouderJul 31, 2020
  37. Junio C HamanoJul 31, 2020
  38. Jeff KingJul 31, 2020
  39. Junio C HamanoJul 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.