Re: [PATCH v5 3/3] ref-filter: add support for %(contents:size)

From: Jeff King <peff@peff.net>
Date: Jul 31, 2020, 17:45 UTC
Message-ID: <20200731174547.GC843002@coredump.intra.peff.net>
In-Reply-To: <21bb2dad-5845-8cee-8f6a-1089ef7cae3b@gmail.com>

On Fri, Jul 31, 2020 at 07:37:22PM +0200, Alban Gruin wrote:

Show 7 quoted lines

> > +		# Leave $expect unquoted to lose possible leading whitespaces
> > +		echo $expect >expected
> > +		test_expect_${4:-sucess} $PREREQ "basic atom: $1 contents:size" '
> 
> There is a typo here, and $expect is written to `expected', but
> `test_cmp' wants `expect'.  Fixing those mistakes does not reveal any
> broken tests.

I thought at first you meant that the typo was s/expected/expect, and wondered how this could possibly have passed. But the typo is s/sucess/success/, so we were in fact not running the test at all (and were generating "test_expect_sucess: not found" messages to stderr, but outside of any test block. Yikes.

Thanks for spotting.

-Peff