Re: [PATCH v6 00/30] Builtin FSMonitor Part 2
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 1, 2022, 19:05 UTC
- Message-ID
- <xmqq35k1qyrw.fsf@gitster.g>
- In-Reply-To
- <pull.1041.v6.git.1646160212.gitgitgadget@gmail.com>
"Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 20 quoted lines
> Here is V6 of Part 2 of my builtin FSmonitor series. > > This version contains mostly cleanup based on feedback from V5. Of note: > > * I squashed in the 1_file fix for p7519. > * I squashed in a commit from part 3 to optionally print the "running > daemon on..." message on stderr. > * I added a note to the documentation about incompatible changes around > core.fsmonitor. > * Removed/rephrased some obsolete NEEDSWORK items. > > Tao has an ongoing parallel series to fix test-chmtime on Windows. > https://lore.kernel.org/all/pull.1166.git.1646041236.gitgitgadget@gmail.com/ > > If that lands first, we should be able to drop my 't/helper/test-chmtime: > skip directories on Windows' commit. > > A followup Part 3 will contain additional refinements to the daemon and > additional tests. I drew the line here between Part 2 and 3 to make it > easier to review.
Hopefully this round will quickly be reviewed solidly to merge it down to 'next' and lower.
Will queue.
Thanks.