Re: [PATCH v6 16/30] compat/fsmonitor/fsm-listen-darwin: add MacOS header files for FSEvent
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Mar 8, 2022, 20:26 UTC
- Message-ID
- <9bc32c17-7249-303f-e579-8992c5bc8497@jeffhostetler.com>
- In-Reply-To
- <220307.86h78a2gcn.gmgdl@evledraar.gmail.com>
On 3/7/22 5:37 AM, Ævar Arnfjörð Bjarmason wrote:
Show 6 quoted lines
> > On Tue, Mar 01 2022, Jeff Hostetler via GitGitGadget wrote: > >> From: Jeff Hostetler <jeffhost@microsoft.com> >> [...] >> +#define kFSEventStreamEventFlagNone 0x00000000
[...]
Show 5 quoted lines
>> +#define kFSEventStreamEventFlagItemCloned 0x00400000 > > Can we define these as 1<<0, 1<<1, 1<<2 etc.? We do that in most other > places, and it helps to quickly eyeball these and see that they don't > have gaps.
All of these constants are defined by Apple in their header files and system documentation. For example, see: https://developer.apple.com/documentation/coreservices/1455361-fseventstreameventflags/kfseventstreameventflagitemcloned
The set is relatively fixed by Apple and we won't be adding any (since they define the bits in a FS event from the kernel).
Changing them to shifts would be wrong.
thanks Jeff