Re: [PATCH v6 19/30] help: include fsmonitor--daemon feature flag in version info

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Mar 8, 2022, 21:19 UTC
Message-ID: <1442043e-d8d4-715a-7534-32f76536eb41@jeffhostetler.com>
In-Reply-To: <220307.86cziy2fvv.gmgdl@evledraar.gmail.com>

On 3/7/22 5:51 AM, Ævar Arnfjörð Bjarmason wrote:

Show 5 quoted lines

> 
> On Tue, Mar 01 2022, Jeff Hostetler via GitGitGadget wrote:
> 
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>

[...]

Show 18 quoted lines

>> +# Does this platform support `git fsmonitor--daemon`
>> +#
>> +test_lazy_prereq FSMONITOR_DAEMON '
>> +	git version --build-options | grep "feature:" | grep "fsmonitor--daemon"
>> +'
> 
> As I found recently (referenced in another series) the test_lazy_prereq
> doesn't currently catch segfaults etc. in git even if test_must_fail and
> friends are used.
> 
> But it's still better to future-proof things and not add more cases of
> git on the LHS of a pipe. So instead:
> 
>      git version .. >out &&
>      grep ...
> 
> The prereqs are run in their own temporary directory, so creating those
> files is OK.

Yes, I think I saw a series on this topic in my inbox recently.

This command is very safe, so I'd rather not reroll just for this.

> 
> Also: You run "grep" here twice, but as the code context shown we could
> just run it once.
>

True, but I think this can wait too.

Thanks, Jeff