Re: [PATCH v5 00/30] Builtin FSMonitor Part 2
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 24, 2022, 15:47 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2202241646430.11118@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqpmnl8evc.fsf@gitster.g>
Hi Junio,
On Thu, 17 Feb 2022, Junio C Hamano wrote:
Show 18 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > >> In this version I removed the core.useBuiltinFSMonitor config setting and > >> instead extended the existing core.fsmonitor. > > > > I am somewhat surprised that a reviewer suggested this, as it breaks the > > common paradigm we use to allow using several Git versions on the same > > worktree. > > I do not think sharing the same repository with different versions > of Git was considered as a possible source of problems during the > review discussion. > > https://lore.kernel.org/git/74282d08-aaeb-0a1e-cad3-1de17d59b4d1@jeffhostetler.com/ > > I am not saying that we should not consider it; I am just stating > the fact that there was nobody who raised as a potential issue > during the discussion that lead to the cited message.
Just to make sure: I did not intend to insult anyone (and in hindsight I wish that I had made that clearer).
Ciao, Dscho