Re: [PATCH v3 2/2] commit-graph.c: no lazy fetch in lookup_commit_in_graph()

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 28, 2022, 17:36 UTC
Message-ID: <xmqq35folmgf.fsf@gitster.g>
In-Reply-To: <220628.865yklgr6g.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 7 quoted lines

>> +test_description='test for no lazy fetch with the commit-graph'
>> +
>> +. ./test-lib.sh
>> +
>> +if ! test_have_prereq ULIMIT_PROCESSES
>
> I think the prereq in 1/2 would be better off squashed into this commit.

Good thinking. It also may make sense to implement it in this file, without touching test-lib.sh at all.

Show 6 quoted lines

>> +test_expect_success 'setup: prepare a repository with commit-graph contains the commit' '
>> +	git init with-commit-graph &&
>> +	echo "$(pwd)/with-commit/.git/objects" \
>> +		>with-commit-graph/.git/objects/info/alternates &&
>
> nit: you can use $PWD instead of $(pwd).

We can, and it would not make any difference on non-Windows.

But which one should we use to cater to Windows? $(pwd) is a full path in Windows notation "C:\Program Files\Git\..." while $PWD is MSYS style "/C/Program Files/Git/..." or something like that, IIRC?