Re: [External] Re: [PATCH v4 1/1] commit-graph.c: no lazy fetch in lookup_commit_in_graph()

From: Jeff King <peff@peff.net>
Date: Jul 12, 2022, 06:37 UTC
Message-ID: <Ys0WlWFIuhP8b2hb@coredump.intra.peff.net>
In-Reply-To: <xmqq1quqkiq2.fsf@gitster.g>

On Mon, Jul 11, 2022 at 10:23:01PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> > The tricky thing about using ulimit is that it's tied to the entire development
> > station. I have tried to run the test without any limit [1], it did finally be
> > canceled after 6 hours.
> 
> I am not worried so much about developer workstation, which people
> are sitting in front of.  They can ^C any runaway test way before 6
> hours just fine.
> 
> I am assuming that we do not have to be worried about CI settings
> too much, either, as they should already be prepared to catch
> run-away processes.

Agreed. Also, I think that although it's natural to worry about a bug we know about causing an infinite loop, it's much more likely that a _new_ bug will cause one. I.e., every test we already carry is a candidate to accidentally loop forever in this way. This is just the one we happen to have seen. Once fixed, I don't know that it's at any more risk of reocurring than any other problem.

-Peff