Re: [PATCH v3 2/2] commit-graph.c: no lazy fetch in lookup_commit_in_graph()
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 30, 2022, 12:21 UTC
- Message-ID
- <5n35o008-pso2-6440-424p-q387q9n4so41@tzk.qr>
- In-Reply-To
- <xmqq35folmgf.fsf@gitster.g>
Hi Junio,
On Tue, 28 Jun 2022, Junio C Hamano wrote:
Show 14 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > > >> +test_expect_success 'setup: prepare a repository with commit-graph contains the commit' ' > >> + git init with-commit-graph && > >> + echo "$(pwd)/with-commit/.git/objects" \ > >> + >with-commit-graph/.git/objects/info/alternates && > > > > nit: you can use $PWD instead of $(pwd). > > We can, and it would not make any difference on non-Windows. > > But which one should we use to cater to Windows? $(pwd) is a full > path in Windows notation "C:\Program Files\Git\..." while $PWD is > MSYS style "/C/Program Files/Git/..." or something like that, IIRC?
Indeed, and since the `alternates` file is supposed to be read by `git.exe`, a non-MSYS program, the original was good, and the nit suggested the incorrect form.
Thank you for catching this before it was worsimproved, Dscho