Re: Re: [PATCH v4 1/1] commit-graph.c: no lazy fetch in lookup_commit_in_graph()
- From
Han Xin <hanxin.hx@bytedance.com>
- Date
- Jul 12, 2022, 05:32 UTC
- Message-ID
- <CAKgqsWW+OECFnEy+uib1W6UzB1Sy_MQ5towDwH28fg=ni1v_0Q@mail.gmail.com>
- In-Reply-To
- <xmqq1quqkiq2.fsf@gitster.g>
On Tue, Jul 12, 2022 at 1:23 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 21 quoted lines
> > Han Xin <hanxin.hx@bytedance.com> writes: > > >> I wonder if we can just run the test without any limit? If in an > >> unattended CI situation, hopefully they will kick the job out due to > >> quota, and on a developer workstation, there may be processes killed > >> left and right, but that is only when the "infinite respawning" bug > >> reappears. > >> > > > > The tricky thing about using ulimit is that it's tied to the entire development > > station. I have tried to run the test without any limit [1], it did finally be > > canceled after 6 hours. > > I am not worried so much about developer workstation, which people > are sitting in front of. They can ^C any runaway test way before 6 > hours just fine. > > I am assuming that we do not have to be worried about CI settings > too much, either, as they should already be prepared to catch > run-away processes.
OK, let's remove the "ulimit" and leave it to the followup checks.
Thanks. -Han Xin