Re: [Patch] test-lib-functions.sh : change test_i18ngrep to test_grep

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 3, 2023, 13:19 UTC
Message-ID: <xmqq34wj4e55.fsf@gitster.g>
In-Reply-To: <ZWw6r2EDGkpgyYEM@five231003>

Kousik Sanagavarapu <five231003@gmail.com> writes:

Show 13 quoted lines

> Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> wrote:
>
>> Subject: [Patch] test-lib-functions.sh : change test_i18ngrep to test_grep
>
> For anyone reading the subject, I think reading
>
> 	change test_i18ngrep to test_grep
>
> would be confusing, as from the looks of it, the patch does remove
> test_i18ngrep() and replace it with test_grep (I mean the plan is to
> remove test_i18ngrep only after we are sure that it doesn't exist in the
> code anywhere, anymore) but only making a change in the wording of an
> error message within test_grep().

;-)

Yes, that was exactly my reaction to the subject (I'm on vacation so I only scanned the subject lines of incoming patches without looking at anything else and thought "hmph, it is good somebody else is cleaning up new uses of test_i18ngrep that have been introduced by topics simultaneously in flight").