Re: [PATCH v2] test-lib-functions.sh: fix test_grep fail message wording

From: Kousik Sanagavarapu <five231003@gmail.com>
Date: Dec 4, 2023, 18:43 UTC
Message-ID: <ZW4d0M3X4MB6FpON@five231003>
In-Reply-To: <20231203171956.771-1-shreyanshpaliwalcmsmn@gmail.com>

On Sun, Dec 03, 2023 at 10:47:59PM +0530, Shreyansh Paliwal wrote:

Show 5 quoted lines

> From: shreyp135 <shreyanshpaliwalcmsmn@gmail.com>
> 
> In the recent commit
> 2e87fca189 (test framework: further deprecate test_i18ngrep, 2023-10-31),
> the test_i18ngrep() function was deprecated.

s/In the/In a

is gramatically correct, but probably not worth a reroll.

> So if a test employing this function fails,
> the error messages may be confusing due to wording issues.

Isn't the confusion due to test_i18ngrep being displayed in place of test_grep and not the other way around? Because the formation of the sentence makes it look like the latter.

Show 24 quoted lines

> It's important to address these wording changes to ensure smooth transitions
> for developers adapting to the deprecation of test_i18ngrep,
> and to maintain the effectiveness of the testing process.
> 
> Signed-off-by: Shreyansh Paliwal <Shreyanshpaliwalcmsmn@gmail.com>
> ---
>  t/test-lib-functions.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> index 9c3cf12b26..8737c95e0c 100644
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -1277,7 +1277,7 @@ test_grep () {
>  	if test $# -lt 2 ||
>  	   { test "x!" = "x$1" && test $# -lt 3 ; }
>  	then
> -		BUG "too few parameters to test_i18ngrep"
> +		BUG "too few parameters to test_grep"
>  	fi
>  
>  	if test "x!" = "x$1"
> -- 
> 2.43.0.1

Rest looks good.

Have a great time at the vacation Junio (and sorry for pinging in the first place... although this email will indirectly ping too :P).

Thanks