git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] test-lib-functions.sh: fix test_grep fail message wording

From
Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
Date
Dec 3, 2023, 17:17 UTC
Message-ID
<20231203171956.771-1-shreyanshpaliwalcmsmn@gmail.com>
In-Reply-To
<CAPYXD64yCuMta_iGE+ZwgxrJn0U5shcwcB9jaiNkFhvff=R7MQ@mail.gmail.com>
From: shreyp135 <shreyanshpaliwalcmsmn@gmail.com>

In the recent commit 2e87fca189 (test framework: further deprecate test_i18ngrep, 2023-10-31), the test_i18ngrep() function was deprecated.

So if a test employing this function fails, the error messages may be confusing due to wording issues.

It's important to address these wording changes to ensure smooth transitions for developers adapting to the deprecation of test_i18ngrep, and to maintain the effectiveness of the testing process.

Signed-off-by: Shreyansh Paliwal <Shreyanshpaliwalcmsmn@gmail.com>
---
 t/test-lib-functions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index 9c3cf12b26..8737c95e0c 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -1277,7 +1277,7 @@ test_grep () {
 	if test $# -lt 2 ||
 	   { test "x!" = "x$1" && test $# -lt 3 ; }
 	then
-		BUG "too few parameters to test_i18ngrep"
+		BUG "too few parameters to test_grep"
 	fi
 
 	if test "x!" = "x$1"
-- 
2.43.0.1
Previous: Junio C HamanoNext: Kousik Sanagavarapu
Message 4 of 10 in “test-lib-functions.sh : change test_i18ngrep to test_grep”
  1. test-lib-functions.sh : change test_i18ngrep to test_grepShreyansh Paliwal, Dec 2, 2023
  2. Kousik SanagavarapuDec 3, 2023
  3. Junio C HamanoDec 3, 2023
  4. test-lib-functions.sh: fix test_grep fail message wordingShreyansh Paliwal, Dec 3, 2023
  5. Kousik SanagavarapuDec 4, 2023
  6. Shreyansh PaliwalDec 17, 2023
  7. Eric SunshineDec 18, 2023
  8. Junio C HamanoDec 18, 2023
  9. Junio C HamanoDec 18, 2023
  10. Eric SunshineDec 18, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.