Re: [PATCH v2] test-lib-functions.sh: fix test_grep fail message wording

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 18, 2023, 18:55 UTC
Message-ID: <CAPig+cTXyfuuY17NmsfDO_5VpeMgXLpqf-Me8wtNs0nCgOW0jA@mail.gmail.com>
In-Reply-To: <xmqqh6kfe4am.fsf@gitster.g>

On Mon, Dec 18, 2023 at 1:47 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Here is the version I queued.
>
> --- >8 ---
> From: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
> Date: Sun, 3 Dec 2023 22:47:59 +0530
> Subject: [PATCH] test-lib-functions.sh: fix test_grep fail message wording
>
> In the recent commit 2e87fca189 (test framework: further deprecate
> test_i18ngrep, 2023-10-31), the test_i18ngrep function was
> deprecated, and all the callers were updated to call the test_grep
> function instead.  But test_grep inherited an error message that
> still refers to test_i18ngrep by mistake.  Correct it so that a
> broken call to the test_grep will identify itself as such.

This rewritten commit message gets directly to the point without wasted words, making the purpose of the patch, and its justification, easier to understand on first read. Nicely done.

> Signed-off-by: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>