git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: setup pager only before diff contents truly ready

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 18, 2024, 00:55 UTC
Message-ID
<xmqq34jpl5sl.fsf@gitster.g>
In-Reply-To
<ZxatqdBiB+NoMP+j@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 10 quoted lines
>> You'd need to identify all of the possible diff code paths in order to
>> add tests for them, which is the same thing you had to do to fix the
>> code paths. I was mostly just commenting that we're not likely to be
>> able to rely on existing tests to help us here.
>>
>> It might be worth adding a test that shows off your improved diff
>> behavior, though I would be OK if it was a representative command and
>> not exhaustive. I think adding to t7006 should be fine.
>
> Agreed.
It seems that this topic is waiting for a reroll?
Previous: Taylor BlauNext: Jeff King
Message 8 of 12 in “diff: setup pager only before diff contents truly ready”
  1. diff: setup pager only before diff contents truly readyY5 via GitGitGadget, Oct 19, 2024
  2. Kristoffer HaugsbakkOct 19, 2024
  3. Philip YungOct 21, 2024
  4. Jeff KingOct 19, 2024
  5. Philip YungOct 21, 2024
  6. Jeff KingOct 21, 2024
  7. Taylor BlauOct 21, 2024
  8. Junio C HamanoNov 18, 2024
  9. Jeff KingNov 25, 2024
  10. Junio C HamanoDec 3, 2024
  11. Jeff KingDec 3, 2024
  12. Junio C HamanoDec 4, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.