From: Junio C Hamano Date: Mon, 18 Nov 2024 00:55:06 GMT Subject: Re: [PATCH] diff: setup pager only before diff contents truly ready Message-ID: In-Reply-To: Taylor Blau writes: >> You'd need to identify all of the possible diff code paths in order to >> add tests for them, which is the same thing you had to do to fix the >> code paths. I was mostly just commenting that we're not likely to be >> able to rely on existing tests to help us here. >> >> It might be worth adding a test that shows off your improved diff >> behavior, though I would be OK if it was a representative command and >> not exhaustive. I think adding to t7006 should be fine. > > Agreed. It seems that this topic is waiting for a reroll?