Re: [PATCH] diff: setup pager only before diff contents truly ready

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Oct 19, 2024, 20:57 UTC
Message-ID: <348f4415-77cb-4893-8388-a2495a391a39@app.fastmail.com>
In-Reply-To: <pull.1817.git.git.1729370390416.gitgitgadget@gmail.com>

On Sat, Oct 19, 2024, at 22:39, Y5 via GitGitGadget wrote:

> From: y5c4l3 <y5c4l3@proton.me>
>
> git-diff setups pager at an early stage in cmd_diff; running diff with
> invalid options like git diff --invalid will unexpectedly starts a

s/starts a/start a/

> pager, which causes behavior inconsistency.
>
> The pager setup routine should be moved right before the real diff
> contents, in case there is any argv error.

*Any* argv error?  Maybe “an argv error”?

“any argv error” looks like there isn’t an agreement on plural/singular.

-- 
Kristoffer Haugsbakk