Re: [PATCH] diff: setup pager only before diff contents truly ready

From: Jeff King <peff@peff.net>
Date: Nov 25, 2024, 11:31 UTC
Message-ID: <20241125113105.GA1070162@coredump.intra.peff.net>
In-Reply-To: <xmqq34jpl5sl.fsf@gitster.g>

On Mon, Nov 18, 2024 at 09:55:06AM +0900, Junio C Hamano wrote:

Show 14 quoted lines

> Taylor Blau <me@ttaylorr.com> writes:
> 
> >> You'd need to identify all of the possible diff code paths in order to
> >> add tests for them, which is the same thing you had to do to fix the
> >> code paths. I was mostly just commenting that we're not likely to be
> >> able to rely on existing tests to help us here.
> >>
> >> It might be worth adding a test that shows off your improved diff
> >> behavior, though I would be OK if it was a representative command and
> >> not exhaustive. I think adding to t7006 should be fine.
> >
> > Agreed.
> 
> It seems that this topic is waiting for a reroll?

I think we could go either way. I outlined a few further possible steps, but there is no need to hold up this first step. The only question is whether or not to add a single test to show off and protect the improvement.

-Peff