git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: sh -x -i -v with continuous integration, was Re: [PATCH 1/4] t7601: test for pull.ff=true overrides merge.ff=false

From
Junio C Hamano <gitster@pobox.com>
Date
May 16, 2015, 19:07 UTC
Message-ID
<xmqq1tigfij8.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150516152858.GA19269@peff.net>
Jeff King <peff@peff.net> writes:
> Do we object to having to sprinkle the "verbose" throughout the test
> scripts?
Yes.  

An unconstrained "verbose" that applies to anything would make people less careful to come up with more useful abstractions, e.g. test_line_count, which I view as a bigger problem.

"verbose test", regardless of how it is spelled, either as two words "verbose test", a "verbose_test" helper, or a helper function that overrides "test", share the same issue, as their unconstrained-ness comes from the fact that test is too broad a command. I'd rather want to see us move more in the direction of encouraging things like test_line_count, which makes it easier to write new tests with less mistakes (e.g. by hiding the BSD wc pitfall "$(wc -l <file)", in test_line_count's case).

Previous: Jeff KingNext: Jeff King
Message 8 of 17 in “make pull.ff=true override merge.ff”
  1. 0/4 make pull.ff=true override merge.ffPaul Tan, May 13, 2015
  2. 1/4 t7601: test for pull.ff=true overrides merge.ff=falsePaul Tan, May 13, 2015
  3. Johannes SchindelinMay 14, 2015
  4. Junio C HamanoMay 14, 2015
  5. sh -x -i -v with continuous integration, was Re: [PATCH 1/4] t7601: test for pull.ff=true overrides merge.ff=falseJohannes Schindelin, May 14, 2015
  6. Junio C HamanoMay 14, 2015
  7. Jeff KingMay 16, 2015
  8. Junio C HamanoMay 16, 2015
  9. Jeff KingMay 18, 2015
  10. Junio C HamanoMay 18, 2015
  11. Jeff KingMay 18, 2015
  12. Junio C HamanoMay 18, 2015
  13. Paul TanMay 16, 2015
  14. 2/4 pull: make pull.ff=true override merge.ffPaul Tan, May 13, 2015
  15. 3/4 Documentation/config.txt: clarify that pull.ff overrides merge.ffPaul Tan, May 13, 2015
  16. 4/4 pull: parse pull.ff as a bool or stringPaul Tan, May 13, 2015
  17. Johannes SchindelinMay 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.