Re: sh -x -i -v with continuous integration, was Re: [PATCH 1/4] t7601: test for pull.ff=true overrides merge.ff=false

From: Jeff King <peff@peff.net>
Date: May 18, 2015, 20:50 UTC
Message-ID: <20150518205008.GB30217@peff.net>
In-Reply-To: <xmqq8uclbouc.fsf@gitster.dls.corp.google.com>

On Mon, May 18, 2015 at 01:41:31PM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> So, I suspect we want more or less the same thing.
> 
> We agree that we need shorter, easier to use, and less error prone
> idioms, like test_cmp (comparing two files and show the differences
> as diagnosis), test_cmp_rev (comparing two extended SHA-1
> expressions as object names), and test_line_count (checking the
> number of lines in a file).  I just do not think "verbose" that can
> apply to any command will help us move in that direction very much,
> and I find that "verbose" applied to something overly versatile like
> "test" is a prime example that it does not help us much.

I'd agree with that if you replace "need" with "it would be nice, but it clearly isn't high enough priority for people to actually write the helpers, so...". :)

I dunno. Maybe there are only a few helpers needed, and we can just add them and start using them. But if we start having to grow a lot of them, it can be annoying.

What do you want to do with the "verbose" calls I have been sprinkling through the test suite (and the function itself)? Leave them or remove them? A grep for "verbose " (with the trailing space) shows some examples.

-Peff