Re: [PATCH 1/2] alternates: accept double-quoted paths

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 13, 2016, 18:08 UTC
Message-ID: <xmqq1sxb66t5.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CACsJy8B52ZDRTUjGLqub_1wELtugv99xbDnBg1PX1LUTb6nVMQ@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 6 quoted lines

> At least attr has the same problem and is going the same direction
> [1]. Cool. (I actually thought the patch was in and evidence that this
> kind of backward compatibility breaking was ok, turns out the patch
> has stayed around for years)
>
> [1] http://public-inbox.org/git/%3C20161110203428.30512-18-sbeller@google.com%3E/

Seeing that again, I see this in the proposed log message:

    Full pattern must be quoted. So 'pat"t"ern attr' will give exactly
    'pat"t"ern', not 'pattern'.

I cannot tell what it is trying to say. The code suggests something quite different, i.e. a line like this

	"pat\"t\"ern" attr

would tell us that a path that matches the pattern

	pat"t"ern

is given 'attr'.

The log message may need to be cleaned up. The update by that commit to the documentation looks alright, thoguh.