Re: [PATCH 1/2] alternates: accept double-quoted paths

From: Duy Nguyen <pclouds@gmail.com>
Date: Dec 17, 2016, 07:56 UTC
Message-ID: <CACsJy8BuLu+A8UBd4OOzQkcQOsWYo-jDi2+MKgH5ujvOSdOO8Q@mail.gmail.com>
In-Reply-To: <xmqq1sxb66t5.fsf@gitster.mtv.corp.google.com>

On Wed, Dec 14, 2016 at 1:08 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Duy Nguyen <pclouds@gmail.com> writes:
>
>> At least attr has the same problem and is going the same direction
>> [1]. Cool. (I actually thought the patch was in and evidence that this
>> kind of backward compatibility breaking was ok, turns out the patch
>> has stayed around for years)
>>
>> [1] http://public-inbox.org/git/%3C20161110203428.30512-18-sbeller@google.com%3E/
>
> Seeing that again, I see this in the proposed log message:
>
>     Full pattern must be quoted. So 'pat"t"ern attr' will give exactly
>     'pat"t"ern', not 'pattern'.
>
> I cannot tell what it is trying to say.

It's another (bad) way of saying that quoting must start at the beginning (so the closing quote must be at the end of pattern, i.e. the whole pattern is quoted).

> The log message may need to be cleaned up.

Yeah. Next time I'll write more or less "Look at Jeff's commit, this is basically it" when Stephan re-rolls sb/attr

-- 
Duy