Re: [PATCH 2/2] tmp-objdir: quote paths we add to alternates

From: Jeff King <peff@peff.net>
Date: Dec 13, 2016, 18:15 UTC
Message-ID: <20161213181538.6gv4it4b33uhbuud@sigill.intra.peff.net>
In-Reply-To: <xmqqwpf34s5f.fsf@gitster.mtv.corp.google.com>

On Tue, Dec 13, 2016 at 10:10:04AM -0800, Junio C Hamano wrote:

Show 5 quoted lines

> > -	git clone --bare . xxx:yyy.git &&
> > +	git clone --bare . xxx${path_sep}yyy.git &&
> 
> Don't you want to dq the whole thing to prevent the shell from
> splitting this into two commands at ';'?  The other one below is OK.

After expansion, I don't think the shell will do any further processing except for whitespace splitting. E.g.:

  $ debug() { for i in "$@"; do echo "got $i"; done; }
  $ sep=';'
  $ space=' '
  $ debug foo${sep}bar
  got foo;bar
  $ debug foo${space}bar
  got foo
  got bar

I don't mind quoting it to make it more obvious, though.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.