Re: [RFC PATCH 0/5] Localise error headers

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 11, 2017, 18:08 UTC
Message-ID: <xmqq1sw9piz5.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170111113725.avl3wetwrfezdni2@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> Yes, I would think die_errno() is a no-brainer for translation, since
> the strerror() will be translated.
>
>>     apply.c:                die(_("internal error"));
>> 
>> That is funny, too. I think we should substitute that with
>> 
>>     die("BUG: untranslated, but what went wrong instead")
>
> Yep. We did not consistently use "BUG:" in the early days. I would say
> that "BUG" lines do not need to be translated. The point is that nobody
> should ever see them, so it seems like there is little point in giving
> extra work to translators.

In addition, "BUG: " is relatively recent introduction to our codebase. Perhaps having a separate BUG(<string>) function help the distinction further?