Re: [RFC PATCH 0/5] Localise error headers

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Jan 9, 2017, 12:43 UTC
Message-ID: <8d0966d0-1ef1-3d1e-95f5-6e6c1ad50536@drmicha.warpmail.net>
In-Reply-To: <20170104070514.pxdthvilw66ierfz@sigill.intra.peff.net>

Jeff King venit, vidit, dixit 04.01.2017 08:05:

Show 15 quoted lines

> On Mon, Jan 02, 2017 at 12:14:49PM +0100, Michael J Gruber wrote:
> 
>> Currently, the headers "error: ", "warning: " etc. - generated by die(),
>> warning() etc. - are not localized, but we feed many localized error messages
>> into these functions so that we produce error messages with mixed localisation.
>>
>> This series introduces variants of die() etc. that use localised variants of
>> the headers, i.e. _("error: ") etc., and are to be fed localized messages. So,
>> instead of die(_("not workee")), which would produce a mixed localisation (such
>> as "error: geht ned"), one should use die_(_("not workee")) (resulting in
>> "Fehler: geht ned").
> 
> I can't say I'm excited about having matching "_" variants for each
> function. Are we sure that they are necessary? I.e., would it be
> acceptable to just translate them always?

We would still need to mark the strings, e.g.

die(N_("oopsie"));

and would not be able to opt out of translating in the code (only in the po file, by not providing a translation).

Show 11 quoted lines

>> 1/5 prepares the error machinery
>> 2/5 provides new variants error_() etc.
>> 3/5 has coccinelli rules error(_(E)) -> error_(_(E)) etc.
>> 4/5 applies the coccinelli patches
>>
>> 5/5 is not to be applied to the main tree, but helps you try out the feature:
>> it has changes to de.po and git.pot so that e.g. "git branch" has fully localised
>> error messages (see the recipe in the commit message).
> 
> Your patches 4 and 5 don't seem to have made it to the list. Judging
> from the diffstat, I'd guess they broke the 100K limit.

Hmmpf, I didn't know about the limit. In any case, they were simple results of applying the "make cocci" patches (4/5) resp. providing some "de" strings to try this out.

In any case, the question is whether we want to tell the user

A: B

where A is in English and B is localised, or rather localise both A and B (for A in "error", "fatal", "warning"...).

For localising A and B, we'd need this series or something similar. For keeping the mix, we don't need to do anything ;)

Michael