Re: [RFC PATCH 0/5] Localise error headers

From: Jeff King <peff@peff.net>
Date: Jan 4, 2017, 07:05 UTC
Message-ID: <20170104070514.pxdthvilw66ierfz@sigill.intra.peff.net>
In-Reply-To: <cover.1483354746.git.git@drmicha.warpmail.net>

On Mon, Jan 02, 2017 at 12:14:49PM +0100, Michael J Gruber wrote:

Show 9 quoted lines

> Currently, the headers "error: ", "warning: " etc. - generated by die(),
> warning() etc. - are not localized, but we feed many localized error messages
> into these functions so that we produce error messages with mixed localisation.
> 
> This series introduces variants of die() etc. that use localised variants of
> the headers, i.e. _("error: ") etc., and are to be fed localized messages. So,
> instead of die(_("not workee")), which would produce a mixed localisation (such
> as "error: geht ned"), one should use die_(_("not workee")) (resulting in
> "Fehler: geht ned").

I can't say I'm excited about having matching "_" variants for each function. Are we sure that they are necessary? I.e., would it be acceptable to just translate them always?

Show 8 quoted lines

> 1/5 prepares the error machinery
> 2/5 provides new variants error_() etc.
> 3/5 has coccinelli rules error(_(E)) -> error_(_(E)) etc.
> 4/5 applies the coccinelli patches
> 
> 5/5 is not to be applied to the main tree, but helps you try out the feature:
> it has changes to de.po and git.pot so that e.g. "git branch" has fully localised
> error messages (see the recipe in the commit message).

Your patches 4 and 5 don't seem to have made it to the list. Judging from the diffstat, I'd guess they broke the 100K limit.

-Peff